Skip to content

Feedback on 500 error page #7106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

Feedback on 500 error page #7106

merged 4 commits into from
May 23, 2025

Conversation

@eshanrnh
Copy link
Contributor

@eshanrnh eshanrnh commented May 22, 2025 •
edited
Loading

Description

  1. Fixed broken links.
  2. Moved the comment out of the code as a separate line to enable copy/pasting the json code without errors.
  3. Added sample code to show different cultures.
  4. Added some context as to when the 500 setup provided in the docs works.
  5. Cleaned the Trigger a 500 error (for testing) section.
  6. Added a Handling app startup failures section to cover app side of things.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

CMS v15 and v16

Deadline (if relevant)

Anytime

@eshanrnh eshanrnh requested a review from sofietoft May 22, 2025 09:37
@eshanrnh
Copy link
Contributor Author

eshanrnh commented May 22, 2025

The term "NGINX" doesn't have a full form in the traditional sense, like an acronym. It's a software name, derived from the Russian word "engine" (pronounced "engine x").

sofietoft
sofietoft reviewed May 23, 2025
View reviewed changes
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

Regarding the acronym - is it something that's necessary to mention?
If it is, add it to the acronym whitelist, to get rid of the warnings 💪

@eshanrnh
Copy link
Contributor Author

eshanrnh commented May 23, 2025

Thanks for the review, @sofietoft 🙌 I've added NGINX to the acronym whitelist as it's mentioned in other places too in the docs.

@eshanrnh
Copy link
Contributor Author

eshanrnh commented May 23, 2025

The sentences are shorter than 25 words. Not sure why it's still failing the check 🤷‍♀️

sofietoft
sofietoft approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great 💪

And yeah, I also tried to count those sentences - not sure why it's failing either 😅

@eshanrnh eshanrnh merged commit 2fd2170 into main May 23, 2025
2 of 9 checks passed
@eshanrnh eshanrnh deleted the 500-errors branch May 23, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sofietoft sofietoft sofietoft approved these changes

Assignees

No one assigned

Labels

category/umbraco-cms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eshanrnh @sofietoft